fix(Android): missing background color for formSheets on RN 0.77+#2660
Merged
fix(Android): missing background color for formSheets on RN 0.77+#2660
Conversation
kkafar
force-pushed
the
@kkafar/formsheet-fixes-background-color
branch
from
7b163de to
0fe34e6
Compare
kkafar
force-pushed
the
@kkafar/formsheet-fixes-background-color
branch
from
320ec31 to
008f5bb
Compare
This was referenced Feb 5, 2025
kkafar
added a commit
that referenced
this pull request
Feb 7, 2025
## Description Recently I've added new directory `android/src/versioned` with several source code files in #2660, however I've forgotten to include this directory in npm whitelist files, so they didn't get included in latest release (4.7.0-beta.2). Fixing this in this PR. ## Test code and steps to reproduce Verified with `npm pack --dry-run` that these files are now included. ## Checklist - [ ] Ensured that CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BackgroundStyleApplicatorColorDrawableused previously byReactViewGrouphas been exchanged forCompositeBackgroundDrawableadded in Add CompositeBackgroundDrawable and BackgroundStyleApplicator facebook/react-native#45688Caution
This PR breaks compatibility with older versions of react-native. While this is fine on Fabric, this also breaks things for Paper.Possible solution is to detect react native version in gradle and add versioned sourcesets with implementations for given react native versions.Not up to date. I've added versioned source files to ensure appropriate backward compatibility down to 0.74.
Note
We need CI to ensure the projects do build on all versions we support.
Changes
Migrated to
BackgroundStyleApplicator APIto resolve background color ofcontentWrapper.Test code and steps to reproduce
TestAndroidTransitions- the form sheet should no longer be cut.Checklist